Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083273004: Fix build with system libvpx (Closed)

Created:
5 years, 8 months ago by Paweł Hajdan Jr.
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/linux/unbundle/libvpx.gyp View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
5 years, 8 months ago (2015-04-21 16:11:36 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1083273004/diff/1/build/linux/unbundle/libvpx.gyp File build/linux/unbundle/libvpx.gyp (right): https://codereview.chromium.org/1083273004/diff/1/build/linux/unbundle/libvpx.gyp#newcode17 build/linux/unbundle/libvpx.gyp:17: 'vpx/vpx_codec_impl_bottom.h', maybe sort the list?
5 years, 8 months ago (2015-04-21 19:21:18 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/1083273004/diff/1/build/linux/unbundle/libvpx.gyp File build/linux/unbundle/libvpx.gyp (right): https://codereview.chromium.org/1083273004/diff/1/build/linux/unbundle/libvpx.gyp#newcode17 build/linux/unbundle/libvpx.gyp:17: 'vpx/vpx_codec_impl_bottom.h', On 2015/04/21 19:21:18, Lei Zhang wrote: > maybe ...
5 years, 8 months ago (2015-04-21 23:50:11 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb840561c3a6484462dec1046ae49fe9613a6f78 Cr-Commit-Position: refs/heads/master@{#326177}
5 years, 8 months ago (2015-04-21 23:52:38 UTC) #5
Paweł Hajdan Jr.
5 years, 8 months ago (2015-04-21 23:52:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
eb840561c3a6484462dec1046ae49fe9613a6f78.

Powered by Google App Engine
This is Rietveld 408576698