disable [add folder] button for media galleries dialog if

disable media galleries if local file access is blocked
by policy.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153077

[Evan Stade, 2012-08-16 01:19:49]

pkasting: views/
erg: chrome_select_file_policy and gtk/
vandebo: media_gallery/

[Peter Kasting, 2012-08-16 03:30:20]

LGTM

http://codereview.chromium.org/10832330/diff/1/chrome/browser/ui/views/extens...
File chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc (right):

http://codereview.chromium.org/10832330/diff/1/chrome/browser/ui/views/extens...
chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc:108: this,
Nit: Or this can go on the end of the previous line.

[Elliot Glaysher, 2012-08-16 16:39:21]

lgtm

[Evan Stade, 2012-08-16 16:47:56]

I just had a thought: perhaps the button should be disabled (greyed out) instead
of hidden, with a tooltip explaining why (similar to the informational infobar
in the select file policy). What do you think?

[vandebo (ex-Chrome), 2012-08-16 17:08:40]

On 2012/08/16 16:47:56, Evan Stade wrote:
> I just had a thought: perhaps the button should be disabled (greyed out)
instead
> of hidden, with a tooltip explaining why (similar to the informational infobar
> in the select file policy). What do you think?

That might be less confusing and frustrating for people who want to add a
gallery and search for instructions on how to do that.  At least they will know
why they can't.

[Evan Stade, 2012-08-16 19:57:44]

ok guys, please re-review dialog_*. Sorry for churn, but it should be quick and
easy.

[Elliot Glaysher, 2012-08-16 20:00:25]

lgtm

[Evan Stade, 2012-08-21 23:12:51]

changed to disallow media galleries api completely if the policy is set.

+asargent for extensions review: Antony, is there a precedent for how to deal
with this sort of thing? Other examples of extension APIs that are in one way or
another disallowed by policy?

[vandebo (ex-Chrome), 2012-08-21 23:24:20]

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:40: *error
= kDisallowedByPolicy;
Is this constant defined somewhere?

[Evan Stade, 2012-08-21 23:56:17]

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:40: *error
= kDisallowedByPolicy;
On 2012/08/21 23:24:20, vandebo wrote:
> Is this constant defined somewhere?

Done. Do you think we should call out the explicit policy?

[vandebo (ex-Chrome), 2012-08-22 00:01:51]

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:40: *error
= kDisallowedByPolicy;
On 2012/08/21 23:56:17, Evan Stade wrote:
> On 2012/08/21 23:24:20, vandebo wrote:
> > Is this constant defined somewhere?
> 
> Done. Do you think we should call out the explicit policy?

That might be nice.

[asargent_no_longer_on_chrome, 2012-08-22 00:20:07]

LGTM

We don't have a lot of examples of things that are disallowed by policies, and I
think so far each one uses the same strategy - just return an error back to the
caller describing what happened.

One case that I can think of that if you have extensions installed by a
mandatory enterprise policy, then extensions aren't allowed to disable/uninstall
them using the chrome.management API
(http://developer.chrome.com/extensions/management.html)

There might be similar cases for enterprise-forced rules on settings that the
chrome.contentSettings and chrome.proxy APIs would otherwise be allowed to set.

[Evan Stade, 2012-08-22 00:31:53]

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

http://codereview.chromium.org/10832330/diff/12001/chrome/browser/extensions/...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:40: *error
= kDisallowedByPolicy;
On 2012/08/22 00:01:51, vandebo wrote:
> On 2012/08/21 23:56:17, Evan Stade wrote:
> > On 2012/08/21 23:24:20, vandebo wrote:
> > > Is this constant defined somewhere?
> > 
> > Done. Do you think we should call out the explicit policy?
> 
> That might be nice.

Done.

[Evan Stade, 2012-08-23 19:01:12]

ping vandebo

[vandebo (ex-Chrome), 2012-08-23 19:52:47]

LGTM