Cosmetic change for disk flush interval in Files.app file copying.

Cosmetic change for disk flush interval in Files.app file copying.

Previously, we have issued a big single flush at the end of the copy
operations. However, the progressbar UI corresponding to it for large
(> 100M) files is "quickly progress to 99%, and keep the user waiting
for dozens of seconds".) This is surely not cool.

This CL changes the behavior to run flush every 10MB progress, which
makes the progress bar to extend more uniformly.

BUG=276276
R=kinuko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241128

[kinaba, 2013-12-13 10:25:44]

One more CL. Could you take a look?

I tried copying 650MB disk image with the current implementation
manually and it didn't look quite good.

[kinuko, 2013-12-13 10:40:57]

ok, lgtm

[kinuko, 2013-12-13 10:42:01]

https://codereview.chromium.org/108323004/diff/1/webkit/browser/fileapi/copy_...
File webkit/browser/fileapi/copy_or_move_operation_delegate.h (right):

https://codereview.chromium.org/108323004/diff/1/webkit/browser/fileapi/copy_...
webkit/browser/fileapi/copy_or_move_operation_delegate.h:85: int64
previous_flush_;
nit: previous_flush_ -> previous_flush_offset_ or something? (I first thought
this might be related to time)

[kinaba, 2013-12-14 05:14:18]

https://codereview.chromium.org/108323004/diff/1/webkit/browser/fileapi/copy_...
File webkit/browser/fileapi/copy_or_move_operation_delegate.h (right):

https://codereview.chromium.org/108323004/diff/1/webkit/browser/fileapi/copy_...
webkit/browser/fileapi/copy_or_move_operation_delegate.h:85: int64
previous_flush_;
On 2013/12/13 10:42:01, kinuko wrote:
> nit: previous_flush_ -> previous_flush_offset_ or something? (I first thought
> this might be related to time)

sg. done.

[commit-bot: I haz the power, 2013-12-14 05:18:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/20001

[commit-bot: I haz the power, 2013-12-14 06:55:04]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-14 07:54:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/20001

[commit-bot: I haz the power, 2013-12-14 08:52:48]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-14 09:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/20001

[commit-bot: I haz the power, 2013-12-14 12:13:37]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-14 14:11:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/20001

[commit-bot: I haz the power, 2013-12-14 16:22:41]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-16 14:05:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/40001

[commit-bot: I haz the power, 2013-12-16 15:21:56]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 15:26:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/40001

[commit-bot: I haz the power, 2013-12-16 16:15:32]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 22:19:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/108323004/40001

[kinaba, 2013-12-17 03:18:51]

Committed patchset #3 manually as r241128 (presubmit successful).