Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083213004: Move createColorSpaceFilter from ImageBuffer to ColorSpaceUtilities (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, Dominik Röttsches, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move createColorSpaceFilter from ImageBuffer to ColorSpaceUtilities Loose method that lacks a strong association with ImageBuffer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M Source/platform/graphics/ColorSpace.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/graphics/ColorSpace.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 8 months ago (2015-04-15 12:43:38 UTC) #2
f(malita)
lgtm
5 years, 8 months ago (2015-04-15 12:46:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083213004/1
5 years, 8 months ago (2015-04-15 13:07:26 UTC) #5
Stephen White
LGTM
5 years, 8 months ago (2015-04-15 13:48:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 14:05:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193789

Powered by Google App Engine
This is Rietveld 408576698