Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1083203002: Stop incorrectly caching brightness values (Closed)

Created:
5 years, 8 months ago by aruslan
Modified:
5 years, 8 months ago
CC:
chromium-reviews, pedro (no code reviews)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop incorrectly caching brightness values NOTE: this change will incur an allocation on every update if the brightness value is less than 1.0. BUG=474612 Committed: https://crrev.com/63f37382e88ffe66d58cd9c19beaf182cd5caca0 Cr-Commit-Position: refs/heads/master@{#325226}

Patch Set 1 #

Patch Set 2 : Retain FilterOperations to reduce frequency of allocations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M chrome/browser/android/compositor/layer/content_layer.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/content_layer.cc View 1 3 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aruslan
Let's talk about this. We have two unrelated drivers of the content_layer filters.
5 years, 8 months ago (2015-04-15 00:40:11 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 8 months ago (2015-04-15 07:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083203002/20001
5 years, 8 months ago (2015-04-15 11:56:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 11:59:29 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:00:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f37382e88ffe66d58cd9c19beaf182cd5caca0
Cr-Commit-Position: refs/heads/master@{#325226}

Powered by Google App Engine
This is Rietveld 408576698