Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1083193006: Rename hasPermission to permissionState. (Closed)

Created:
5 years, 8 months ago by Miguel Garcia
Modified:
5 years, 8 months ago
CC:
blink-reviews, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update global-interface-listing-expected #

Patch Set 3 : #

Patch Set 4 : Revert change in RuntimeEnabledFeatures.in #

Patch Set 5 : re-add hasPermission to the expectations file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -246 lines) Patch
D LayoutTests/http/tests/push_messaging/has-permission-default-in-document.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/has-permission-default-in-service-worker.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/has-permission-denied-in-document.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/has-permission-denied-in-service-worker.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/has-permission-granted-in-document.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/has-permission-granted-in-service-worker.html View 1 chunk +0 lines, -41 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/interfaces.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-default-in-document.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-default-in-service-worker.html View 2 chunks +5 lines, -5 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-denied-in-document.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-denied-in-service-worker.html View 2 chunks +5 lines, -5 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-granted-in-document.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/http/tests/push_messaging/permission-state-granted-in-service-worker.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushManager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushManager.cpp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushManager.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Miguel Garcia
5 years, 8 months ago (2015-04-22 17:15:01 UTC) #4
Miguel Garcia
This follows the spec change agreed on https://github.com/w3c/push-api/issues/136
5 years, 8 months ago (2015-04-22 17:15:43 UTC) #5
Michael van Ouwerkerk
This change lgtm but if you submit it now, the PushMessagingBrowserTest will start failing because ...
5 years, 8 months ago (2015-04-22 17:45:40 UTC) #6
Miguel Garcia
Adding mkwst for Source/platform/RuntimeEnabledFeatures.in OWNERS
5 years, 8 months ago (2015-04-24 11:25:54 UTC) #8
Mike West
LGTM.
5 years, 8 months ago (2015-04-24 12:32:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083193006/100001
5 years, 8 months ago (2015-04-24 12:34:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/60697)
5 years, 8 months ago (2015-04-24 15:04:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083193006/120001
5 years, 8 months ago (2015-04-24 15:25:12 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 16:35:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194410

Powered by Google App Engine
This is Rietveld 408576698