Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083193005: WIP: new.target (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

WIP: new.target LOG=N

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fix return from new func #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -57 lines) Patch
M src/ast.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/ast.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/frames-inl.h View 2 chunks +21 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/parser.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/parser.cc View 9 chunks +31 lines, -9 lines 0 comments Download
M src/preparse-data.h View 6 chunks +13 lines, -3 lines 0 comments Download
M src/preparse-data-format.h View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.h View 10 chunks +62 lines, -0 lines 0 comments Download
M src/preparser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/scopes.h View 5 chunks +16 lines, -2 lines 0 comments Download
M src/scopes.cc View 8 chunks +35 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 11 chunks +34 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +76 lines, -9 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/1083193005/diff/20001/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1083193005/diff/20001/src/runtime/runtime-classes.cc#newcode474 src/runtime/runtime-classes.cc:474: return frame->NewTarget(); This is to make debugging easier... it ...
5 years, 8 months ago (2015-04-21 17:46:03 UTC) #3
arv (Not doing code reviews)
Right now this segfaults for class B { constructor() { print(new.target); } } class D ...
5 years, 8 months ago (2015-04-21 17:49:30 UTC) #4
arv (Not doing code reviews)
5 years, 8 months ago (2015-04-21 18:01:57 UTC) #5 
Fix return from new func

Powered by Google App Engine
This is Rietveld 408576698