Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index b41a6f1f819f49552ec90f372ff7418793627cf1..dd03732b50a91fe9902baf62fc07495a1fcbd802 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -1801,7 +1801,7 @@ bool HTMLInputElement::setupDateTimeChooserParameters(DateTimeChooserParameters&
parameters.maximum = maximum();
parameters.required = isRequired();
if (!RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
- parameters.locale = defaultLanguage();
+ parameters.locale = AtomicString(defaultLanguage());
eseidel 2013/12/31 23:22:35 language shoudl always be an AtomicSTring, surpris
Inactive 2014/01/01 19:26:29 It does not look like it is used in more than one
else {
AtomicString computedLocale = computeInheritedLanguage();
parameters.locale = computedLocale.isEmpty() ? AtomicString(defaultLanguage()) : computedLocale;

Powered by Google App Engine
This is Rietveld 408576698