Source/core/html/HTMLFormElement.cpp - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLAnchorElement.cpp ('K') | « Source/core/html/HTMLAudioElement.cpp ('k') | Source/core/html/HTMLFrameElementBase.cpp » ('j') | Source/core/html/HTMLFrameElementBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLFormElement.cpp

diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp

index 27cda28db711fd309792ac4531f80998dfcecf55..8b8a8ba9dbb7fb8a05a05e0cc11923fbed29c8ff 100644

--- a/Source/core/html/HTMLFormElement.cpp

+++ b/Source/core/html/HTMLFormElement.cpp

@@ -400,7 +400,7 @@ void HTMLFormElement::scheduleFormSubmission(PassRefPtr<FormSubmission> submissi

return;

}

- Frame* targetFrame = document().frame()->loader().findFrameForNavigation(submission->target(), submission->state()->sourceDocument());

+ Frame* targetFrame = document().frame()->loader().findFrameForNavigation(AtomicString(submission->target()), submission->state()->sourceDocument());

if (!targetFrame) {

if (!DOMWindow::allowPopUp(document().frame()) && !UserGestureIndicator::processingUserGesture())

return;