Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: Source/core/html/track/TextTrackCue.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 TextTrack* TextTrackCue::track() const 76 TextTrack* TextTrackCue::track() const
77 { 77 {
78 return m_track; 78 return m_track;
79 } 79 }
80 80
81 void TextTrackCue::setTrack(TextTrack* track) 81 void TextTrackCue::setTrack(TextTrack* track)
82 { 82 {
83 m_track = track; 83 m_track = track;
84 } 84 }
85 85
86 void TextTrackCue::setId(const String& id) 86 void TextTrackCue::setId(const AtomicString& id)
87 { 87 {
88 if (m_id == id) 88 if (m_id == id)
89 return; 89 return;
90 90
91 cueWillChange(); 91 cueWillChange();
92 m_id = id; 92 m_id = id;
93 cueDidChange(); 93 cueDidChange();
94 } 94 }
95 95
96 void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState) 96 void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 if (!active) 168 if (!active)
169 removeDisplayTree(); 169 removeDisplayTree();
170 } 170 }
171 171
172 const AtomicString& TextTrackCue::interfaceName() const 172 const AtomicString& TextTrackCue::interfaceName() const
173 { 173 {
174 return EventTargetNames::TextTrackCue; 174 return EventTargetNames::TextTrackCue;
175 } 175 }
176 176
177 } // namespace WebCore 177 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698