Source/core/html/HTMLViewSourceDocument.h - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Side by Side Diff: Source/core/html/HTMLViewSourceDocument.h

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 void processEndOfFileToken(const String& source, HTMLToken&);	51 void processEndOfFileToken(const String& source, HTMLToken&);

52 void processTagToken(const String& source, HTMLToken&);	52 void processTagToken(const String& source, HTMLToken&);

53 void processCommentToken(const String& source, HTMLToken&);	53 void processCommentToken(const String& source, HTMLToken&);

54 void processCharacterToken(const String& source, HTMLToken&);	54 void processCharacterToken(const String& source, HTMLToken&);

55	55

56 void createContainingTable();	56 void createContainingTable();

57 PassRefPtr<Element> addSpanWithClassName(const AtomicString&);	57 PassRefPtr<Element> addSpanWithClassName(const AtomicString&);

58 void addLine(const AtomicString& className);	58 void addLine(const AtomicString& className);

59 void finishLine();	59 void finishLine();

60 void addText(const String& text, const AtomicString& className);	60 void addText(const String& text, const AtomicString& className);

61 int addRange(const String& source, int start, int end, const String& classNa me, bool isLink = false, bool isAnchor = false, const String& link = String());	61 int addRange(const String& source, int start, int end, const AtomicString& c lassName, bool isLink = false, bool isAnchor = false, const AtomicString& link = nullAtom);
	eseidel 2014/01/02 19:18:28 Bools as arguments are sooooo bad. We really need Bools as arguments are sooooo bad. We really need to make a style rule to yell at us when we try to add more. (I know this has nothing to do with your patch.
62 PassRefPtr<Element> addLink(const AtomicString& url, bool isAnchor);	62 PassRefPtr<Element> addLink(const AtomicString& url, bool isAnchor);

63 PassRefPtr<Element> addBase(const AtomicString& href);	63 PassRefPtr<Element> addBase(const AtomicString& href);

64	64

65 String m_type;	65 String m_type;

66 RefPtr<Element> m_current;	66 RefPtr<Element> m_current;

67 RefPtr<HTMLTableSectionElement> m_tbody;	67 RefPtr<HTMLTableSectionElement> m_tbody;

68 RefPtr<HTMLTableCellElement> m_td;	68 RefPtr<HTMLTableCellElement> m_td;

69 int m_lineNumber;	69 int m_lineNumber;

70 };	70 };

71	71

72 }	72 }

73	73

74 #endif // HTMLViewSourceDocument_h	74 #endif // HTMLViewSourceDocument_h

OLD	NEW