Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/html/HTMLOutputElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 Google Inc. All rights reserved. 2 * Copyright (c) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 setFor(value); 68 setFor(value);
69 else 69 else
70 HTMLFormControlElement::parseAttribute(name, value); 70 HTMLFormControlElement::parseAttribute(name, value);
71 } 71 }
72 72
73 DOMSettableTokenList* HTMLOutputElement::htmlFor() const 73 DOMSettableTokenList* HTMLOutputElement::htmlFor() const
74 { 74 {
75 return m_tokens.get(); 75 return m_tokens.get();
76 } 76 }
77 77
78 void HTMLOutputElement::setFor(const String& value) 78 void HTMLOutputElement::setFor(const AtomicString& value)
79 { 79 {
80 m_tokens->setValue(value); 80 m_tokens->setValue(value);
81 } 81 }
82 82
83 void HTMLOutputElement::childrenChanged(bool createdByParser, Node* beforeChange , Node* afterChange, int childCountDelta) 83 void HTMLOutputElement::childrenChanged(bool createdByParser, Node* beforeChange , Node* afterChange, int childCountDelta)
84 { 84 {
85 HTMLFormControlElement::childrenChanged(createdByParser, beforeChange, after Change, childCountDelta); 85 HTMLFormControlElement::childrenChanged(createdByParser, beforeChange, after Change, childCountDelta);
86 86
87 if (createdByParser || m_isSetTextContentInProgress) { 87 if (createdByParser || m_isSetTextContentInProgress) {
88 m_isSetTextContentInProgress = false; 88 m_isSetTextContentInProgress = false;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 } 135 }
136 136
137 void HTMLOutputElement::setTextContentInternal(const String& value) 137 void HTMLOutputElement::setTextContentInternal(const String& value)
138 { 138 {
139 ASSERT(!m_isSetTextContentInProgress); 139 ASSERT(!m_isSetTextContentInProgress);
140 m_isSetTextContentInProgress = true; 140 m_isSetTextContentInProgress = true;
141 setTextContent(value); 141 setTextContent(value);
142 } 142 }
143 143
144 } // namespace 144 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698