Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/html/HTMLAudioElement.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 PassRefPtr<HTMLAudioElement> HTMLAudioElement::create(Document& document, bool c reatedByParser) 41 PassRefPtr<HTMLAudioElement> HTMLAudioElement::create(Document& document, bool c reatedByParser)
42 { 42 {
43 RefPtr<HTMLAudioElement> audioElement(adoptRef(new HTMLAudioElement(document , createdByParser))); 43 RefPtr<HTMLAudioElement> audioElement(adoptRef(new HTMLAudioElement(document , createdByParser)));
44 audioElement->suspendIfNeeded(); 44 audioElement->suspendIfNeeded();
45 return audioElement.release(); 45 return audioElement.release();
46 } 46 }
47 47
48 PassRefPtr<HTMLAudioElement> HTMLAudioElement::createForJSConstructor(Document& document, const AtomicString& src) 48 PassRefPtr<HTMLAudioElement> HTMLAudioElement::createForJSConstructor(Document& document, const AtomicString& src)
49 { 49 {
50 RefPtr<HTMLAudioElement> audio = adoptRef(new HTMLAudioElement(document, fal se)); 50 RefPtr<HTMLAudioElement> audio = adoptRef(new HTMLAudioElement(document, fal se));
51 audio->setPreload("auto"); 51 audio->setPreload(AtomicString("auto", AtomicString::ConstructFromLiteral));
52 if (!src.isNull()) 52 if (!src.isNull())
53 audio->setSrc(src); 53 audio->setSrc(src);
54 audio->suspendIfNeeded(); 54 audio->suspendIfNeeded();
55 return audio.release(); 55 return audio.release();
56 } 56 }
57 57
58 } 58 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698