Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1083123002: Rename SkNi to SkNb. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkNi to SkNb. As used today, SkNi is used in bool-y contexts. This keeps that, but under a new name, SkNb. This makes room for a new SkNi that's focused on integer-y things like loads, stores, arithmetic, etc. The main reason to split these is that we want different specializations for each use case: for bools, it's important for us to specialize 32- and 64-bit to support efficient float- and double- comparisons, but for integer work we're more likely to be looking at 8- and 16- bit lanes. Keeping these use cases siloed helps me manage the compexity of the backend NEON and SSE code. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8fe8fffdfa7464c6f7da773b8660a2043f4998e0

Patch Set 1 #

Patch Set 2 : nb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -122 lines) Patch
M src/core/SkNx.h View 1 6 chunks +42 lines, -45 lines 0 comments Download
M src/core/SkRect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkNx_neon.h View 6 chunks +42 lines, -46 lines 0 comments Download
M src/opts/SkNx_sse.h View 9 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083123002/20001
5 years, 8 months ago (2015-04-14 18:32:29 UTC) #3
mtklein_C
5 years, 8 months ago (2015-04-14 18:32:29 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-14 18:39:09 UTC) #6
reed1
lgtm
5 years, 8 months ago (2015-04-14 18:48:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083123002/20001
5 years, 8 months ago (2015-04-14 18:49:03 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 18:49:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8fe8fffdfa7464c6f7da773b8660a2043f4998e0

Powered by Google App Engine
This is Rietveld 408576698