Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1083093004: Removing unnecessary blink::prefix (Closed)

Created:
5 years, 8 months ago by a.berwal
Modified:
5 years, 8 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unnecessary blink::prefix Removing unnecessary blink::prefix wherever it is not needed. BUG=477256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194210

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : trybot fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/LinkHighlight.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupMenuTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/painting/PaintAggregator.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/web/painting/PaintAggregator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M Source/web/win/WebFontRendering.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
a.berwal
PTAL
5 years, 8 months ago (2015-04-22 10:14:41 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-22 10:37:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083093004/1
5 years, 8 months ago (2015-04-22 10:38:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/42663) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 8 months ago (2015-04-22 10:43:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083093004/20001
5 years, 8 months ago (2015-04-22 11:08:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/58853)
5 years, 8 months ago (2015-04-22 11:36:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083093004/40001
5 years, 8 months ago (2015-04-22 11:53:42 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:00:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194210

Powered by Google App Engine
This is Rietveld 408576698