Reland "Migrate error messages, part 2."

src/runtime.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This files contains runtime support implemented in JavaScript.
 
 // CAUTION: Some of the functions specified in this file are called
 // directly from compiled code. These are the functions with names in
 // ALL CAPS. The compiled code passes the first argument in 'this'.
 
@@ skipping 361 matching lines @@
   if (%HasProperty(this, string)) return string;
   return 0;
 }
 
 
 function CALL_NON_FUNCTION() {
   var delegate = %GetFunctionDelegate(this);
   if (!IS_FUNCTION(delegate)) {
     var callsite = %RenderCallSite();
     if (callsite == "") callsite = typeof this;
-    throw %MakeTypeError('called_non_callable', [callsite]);
+    throw %MakeTypeError(kCalledNonCallable, callsite);
   }
   return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
 }
 
 
 function CALL_NON_FUNCTION_AS_CONSTRUCTOR() {
   var delegate = %GetConstructorDelegate(this);
   if (!IS_FUNCTION(delegate)) {
     var callsite = %RenderCallSite();
     if (callsite == "") callsite = typeof this;
-    throw %MakeTypeError('called_non_callable', [callsite]);
+    throw %MakeTypeError(kCalledNonCallable, callsite);
   }
   return %Apply(delegate, this, arguments, 0, %_ArgumentsLength());
 }
 
 
 function CALL_FUNCTION_PROXY() {
   var arity = %_ArgumentsLength() - 1;
   var proxy = %_Arguments(arity);  // The proxy comes in as an additional arg.
   var trap = %GetCallTrap(proxy);
   return %Apply(trap, this, arguments, 0, arity);
@@ skipping 52 matching lines @@
   // that takes care of more eventualities.
   if (IS_ARRAY(args)) {
     length = args.length;
     if (%_IsSmi(length) && length >= 0 && length < kSafeArgumentsLength &&
         IS_SPEC_FUNCTION(this)) {
       return length;
     }
   }
 
   if (!IS_SPEC_FUNCTION(this)) {
-    throw %MakeTypeError('called_non_callable', [ %ToString(this) ]);
+    throw %MakeTypeError(kCalledNonCallable, %ToString(this));
   }
 
   if (!IS_SPEC_OBJECT(args)) {
     throw %MakeTypeError('reflect_apply_wrong_args', [ ]);
   }
 
   length = %ToLength(args.length);
 
   // We can handle any number of apply arguments if the stack is
   // big enough, but sanity check the value to avoid overflow when
@@ skipping 19 matching lines @@
   if (IS_ARRAY(args)) {
     length = args.length;
     if (%_IsSmi(length) && length >= 0 && length < kSafeArgumentsLength &&
         ctorOk && newTargetOk) {
       return length;
     }
   }
 
   if (!ctorOk) {
     if (!IS_SPEC_FUNCTION(this)) {
-      throw %MakeTypeError('called_non_callable', [ %ToString(this) ]);
+      throw %MakeTypeError(kCalledNonCallable, %ToString(this));
     } else {
       throw %MakeTypeError('not_constructor', [ %ToString(this) ]);
     }
   }
 
   if (!newTargetOk) {
     if (!IS_SPEC_FUNCTION(newTarget)) {
-      throw %MakeTypeError('called_non_callable', [ %ToString(newTarget) ]);
+      throw %MakeTypeError(kCalledNonCallable, %ToString(newTarget));
     } else {
       throw %MakeTypeError('not_constructor', [ %ToString(newTarget) ]);
     }
   }
 
   if (!IS_SPEC_OBJECT(args)) {
     throw %MakeTypeError('reflect_construct_wrong_args', [ ]);
   }
 
   length = %ToLength(args.length);
@@ skipping 260 matching lines @@
 
 /* -----------------------------------------------
    - - -   J a v a S c r i p t   S t u b s   - - -
    -----------------------------------------------
 */
 
 function STRING_LENGTH_STUB(name) {
   var receiver = this;  // implicit first parameter
   return %_StringGetLength(%_JSValueGetValue(receiver));
 }