Reland "Migrate error messages, part 2."

src/harmony-array.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 // This file relies on the fact that the following declaration has been made
 // in runtime.js:
 // var $Array = global.Array;
 
 // -------------------------------------------------------------------
 
 // ES6 draft 07-15-13, section 15.4.3.23
 function ArrayFind(predicate /* thisArg */) {  // length == 1
   CHECK_OBJECT_COERCIBLE(this, "Array.prototype.find");
 
   var array = ToObject(this);
   var length = ToInteger(array.length);
 
   if (!IS_SPEC_FUNCTION(predicate)) {
-    throw MakeTypeError('called_non_callable', [predicate]);
+    throw MakeTypeError(kCalledNonCallable, predicate);
   }
 
   var thisArg;
   if (%_ArgumentsLength() > 1) {
     thisArg = %_Arguments(1);
   }
 
   var needs_wrapper = false;
   if (IS_NULL_OR_UNDEFINED(thisArg)) {
     thisArg = %GetDefaultReceiver(predicate) || thisArg;
@@ skipping 16 matching lines @@
 
 
 // ES6 draft 07-15-13, section 15.4.3.24
 function ArrayFindIndex(predicate /* thisArg */) {  // length == 1
   CHECK_OBJECT_COERCIBLE(this, "Array.prototype.findIndex");
 
   var array = ToObject(this);
   var length = ToInteger(array.length);
 
   if (!IS_SPEC_FUNCTION(predicate)) {
-    throw MakeTypeError('called_non_callable', [predicate]);
+    throw MakeTypeError(kCalledNonCallable, predicate);
   }
 
   var thisArg;
   if (%_ArgumentsLength() > 1) {
     thisArg = %_Arguments(1);
   }
 
   var needs_wrapper = false;
   if (IS_NULL_OR_UNDEFINED(thisArg)) {
     thisArg = %GetDefaultReceiver(predicate) || thisArg;
@@ skipping 58 matching lines @@
   return array;
 }
 
 // ES6, draft 10-14-14, section 22.1.2.1
 function ArrayFrom(arrayLike, mapfn, receiver) {
   var items = ToObject(arrayLike);
   var mapping = !IS_UNDEFINED(mapfn);
 
   if (mapping) {
     if (!IS_SPEC_FUNCTION(mapfn)) {
-      throw MakeTypeError('called_non_callable', [ mapfn ]);
+      throw MakeTypeError(kCalledNonCallable, mapfn);
     } else if (IS_NULL_OR_UNDEFINED(receiver)) {
       receiver = %GetDefaultReceiver(mapfn) || receiver;
     } else if (!IS_SPEC_OBJECT(receiver) && %IsSloppyModeFunction(mapfn)) {
       receiver = ToObject(receiver);
     }
   }
 
   var iterable = GetMethod(items, symbolIterator);
   var k;
   var result;
@@ skipping 84 matching lines @@
 
   // Set up the non-enumerable functions on the Array prototype object.
   InstallFunctions($Array.prototype, DONT_ENUM, [
     "find", ArrayFind,
     "findIndex", ArrayFindIndex,
     "fill", ArrayFill
   ]);
 }
 
 HarmonyArrayExtendArrayPrototype();