Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083083004: Reland "Migrate error messages, part 2." (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Migrate error messages, part 2." Committed: https://crrev.com/ae2057e81a002ccc3ed540373d503fcb6dee9b8a Cr-Commit-Position: refs/heads/master@{#27907}

Patch Set 1 #

Patch Set 2 : fix for layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -214 lines) Patch
M src/array.js View 7 chunks +7 lines, -17 lines 0 comments Download
M src/array-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/collection.js View 15 chunks +28 lines, -34 lines 0 comments Download
M src/collection-iterator.js View 7 chunks +14 lines, -14 lines 0 comments Download
M src/execution.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/factory.h View 2 chunks +20 lines, -8 lines 0 comments Download
M src/factory.cc View 2 chunks +18 lines, -10 lines 0 comments Download
M src/generator.js View 3 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -3 lines 0 comments Download
M src/messages.h View 1 chunk +11 lines, -3 lines 0 comments Download
M src/messages.js View 5 chunks +14 lines, -32 lines 0 comments Download
M src/objects.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M src/regexp.js View 4 chunks +8 lines, -8 lines 0 comments Download
M src/runtime.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/string-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/symbol.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/typedarray.js View 5 chunks +14 lines, -20 lines 0 comments Download
M src/v8natives.js View 4 chunks +7 lines, -7 lines 0 comments Download
M src/weak-collection.js View 9 chunks +16 lines, -16 lines 0 comments Download
A test/mjsunit/messages.js View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
Hi Michael, this patch got reverted yesterday due to a layout test failure. I found ...
5 years, 8 months ago (2015-04-17 06:55:36 UTC) #2
mvstanton
Right on, try again! LGTM.
5 years, 8 months ago (2015-04-17 08:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083083004/20001
5 years, 8 months ago (2015-04-17 08:34:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 08:36:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 08:36:13 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ae2057e81a002ccc3ed540373d503fcb6dee9b8a
Cr-Commit-Position: refs/heads/master@{#27907}

Powered by Google App Engine
This is Rietveld 408576698