Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1083083002: VectorICs: megamorphic keyed loads in crankshaft don't need a vector. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: megamorphic keyed loads in crankshaft don't need a vector. This needs "Pass load ic state through the Oracle" (https://codereview.chromium.org/1083933002/) to land first. BUG= R=dcarney@chromium.org Committed: https://crrev.com/776770c0e4e9cffad408581962ca90f247ac66f0 Cr-Commit-Position: refs/heads/master@{#27827}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +13 lines, -16 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Dan, This is the same CL you reviewed a day ago, but as discussed, ...
5 years, 8 months ago (2015-04-14 16:37:23 UTC) #1
dcarney
lgtm
5 years, 8 months ago (2015-04-14 18:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083083002/20001
5 years, 8 months ago (2015-04-15 02:00:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 02:35:45 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 02:35:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/776770c0e4e9cffad408581962ca90f247ac66f0
Cr-Commit-Position: refs/heads/master@{#27827}

Powered by Google App Engine
This is Rietveld 408576698