Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1083023002: [Android WebView] Fix up and re-indent some of the tests (Closed)

Created:
5 years, 8 months ago by mnaganov (inactive)
Modified:
5 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Fix up and re-indent some of the tests While working on some other issue, I have noticed that `AwTestBase.loadUrl` doesn't call the same overload of `AwContents.loadUrl` that WebView API does, which can lead to different behaviour of tests vs. real apps. Also, fixed some stuff in `AwContentsTest.testJavaBridge`, and figured out that this test works despite what our documentation says about availability of injected objects, filed http://crbug.com/476880. Committed: https://crrev.com/7d82b15aae9bac0ab0c9925a46cd3ab3b44aed7e Cr-Commit-Position: refs/heads/master@{#325421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 6 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mnaganov (inactive)
PTAL, a trivial change.
5 years, 8 months ago (2015-04-14 12:15:19 UTC) #2
mnaganov (inactive)
Ping?
5 years, 8 months ago (2015-04-16 10:56:54 UTC) #3
Torne
LGTM; sorry, this got buried :)
5 years, 8 months ago (2015-04-16 11:23:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083023002/1
5 years, 8 months ago (2015-04-16 11:29:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 11:52:17 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 11:53:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d82b15aae9bac0ab0c9925a46cd3ab3b44aed7e
Cr-Commit-Position: refs/heads/master@{#325421}

Powered by Google App Engine
This is Rietveld 408576698