Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: Source/bindings/core/v8/ToV8.h

Issue 1083003004: bindings: Moves toV8 and v8SetReturnValue out to ToV8.h and V8Binding.h. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/core/v8/ToV8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ToV8.h
diff --git a/Source/bindings/core/v8/ToV8.h b/Source/bindings/core/v8/ToV8.h
index 9f37c3a4c8388bb1801940ef255c82779db7cf68..0aa9f0e205b2a8737491a55a6ab0c68e9e2b0545 100644
--- a/Source/bindings/core/v8/ToV8.h
+++ b/Source/bindings/core/v8/ToV8.h
@@ -48,7 +48,7 @@ inline v8::Handle<v8::Value> toV8(Node* impl, v8::Handle<v8::Object> creationCon
return ScriptWrappable::fromNode(impl)->wrap(creationContext, isolate);
}
-// [Custom=ToV8]
+// Special versions for DOMWindow, WorkerGlobalScope and EventTarget
CORE_EXPORT v8::Handle<v8::Value> toV8(DOMWindow*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
CORE_EXPORT v8::Handle<v8::Value> toV8(EventTarget*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
@@ -191,7 +191,7 @@ inline v8::Handle<v8::Value> toV8(const ScriptValue& value, v8::Handle<v8::Objec
inline v8::Handle<v8::Value> toV8(const Dictionary& value, v8::Handle<v8::Object> creationContext, v8::Isolate*)
{
- ASSERT_NOT_REACHED();
+ RELEASE_ASSERT_NOT_REACHED();
return v8::Handle<v8::Value>();
}
« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/core/v8/ToV8.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698