Reland of https://codereview.chromium.org/1087133005/ (Add a WinHeap dump provider to the memory pr…

Reland of https://codereview.chromium.org/1087133005/ (Add a WinHeap dump provider to the memory profiler.)

Reason for reland: A flaky test has been removed. (WinHeapDumpProviderTest.GetHeapInformation)

Add a WinHeap dump provider to the memory profiler.

TBR=nduca@chromium.org
BUG=466141
Committed: https://crrev.com/b2f7e9c9d02f5f5760987f1ab750fceaf41f0bec
Cr-Commit-Position: refs/heads/master@{#326771}

[Sébastien Marchand, 2015-04-24 09:03:55]

Patchset #1 (id:1) has been deleted

[Sébastien Marchand, 2015-04-24 09:04:18]

sebmarchand@chromium.org changed reviewers:
+ primiano@chromium.org

[Sébastien Marchand, 2015-04-24 09:04:19]

PTAL.

[Primiano Tucci (use gerrit), 2015-04-24 09:17:45]

LGTM.
May the force be with you this time :)

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
File base/trace_event/winheap_dump_provider_win.cc (right):

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
base/trace_event/winheap_dump_provider_win.cc:42:
DCHECK_NE(reinterpret_cast<ProcessMemoryDump*>(nullptr), pmd);
remove this.

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
File base/trace_event/winheap_dump_provider_win_unittest.cc (right):

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
base/trace_event/winheap_dump_provider_win_unittest.cc:21:
ASSERT_NE(reinterpret_cast<WinHeapDumpProvider*>(nullptr),
just ASSERT here (or static_cast)

[Sébastien Marchand, 2015-04-24 09:20:45]

Thanks !

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
File base/trace_event/winheap_dump_provider_win.cc (right):

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
base/trace_event/winheap_dump_provider_win.cc:42:
DCHECK_NE(reinterpret_cast<ProcessMemoryDump*>(nullptr), pmd);
On 2015/04/24 09:17:44, Primiano Tucci wrote:
> remove this.

Done.

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
File base/trace_event/winheap_dump_provider_win_unittest.cc (right):

https://codereview.chromium.org/1083003003/diff/20001/base/trace_event/winhea...
base/trace_event/winheap_dump_provider_win_unittest.cc:21:
ASSERT_NE(reinterpret_cast<WinHeapDumpProvider*>(nullptr),
On 2015/04/24 09:17:44, Primiano Tucci wrote:
> just ASSERT here (or static_cast)

Done.

[Sébastien Marchand, 2015-04-24 10:23:28]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-04-24 10:23:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1083003003/#ps40001
(title: "Remove the reinterpret_cast.")

[commit-bot: I haz the power, 2015-04-24 10:23:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083003003/40001

[commit-bot: I haz the power, 2015-04-24 11:30:59]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-24 11:31:56]

Patchset 2 (id:??) landed as
https://crrev.com/b2f7e9c9d02f5f5760987f1ab750fceaf41f0bec
Cr-Commit-Position: refs/heads/master@{#326771}