Force full GC whenever CollectAllGarbage is meant to trigger a full GC.

Force full GC whenever CollectAllGarbage is meant to trigger a full GC.

Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site.

Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC.

BUG=

Committed: https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1
Cr-Commit-Position: refs/heads/master@{#27831}

[Hannes Payer (out of office), 2015-04-14 06:58:46]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2015-04-14 07:17:18]

lgtm

[ulan, 2015-04-14 11:56:49]

lgtm if the comments are addressed.

Nit: remove comma in description "Default mode for CollectAllGarbage is,
finalize incremental marking and perform a full GC"

https://codereview.chromium.org/1082973003/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1082973003/diff/40001/src/heap/heap.h#newcode760
src/heap/heap.h:760: static const int kFinalizeIncrementalMarkingMask = 3;
This should be 4, otherwise it is the same as (kReduceMemoryFootprintMask  |
kAbortIncrementalMarkingMask)

https://codereview.chromium.org/1082973003/diff/40001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1082973003/diff/40001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:27: ((flags & Heap::kFinalizeIncrementalMarkingMask)
!= 0);
DCHECK(!finalize_incremental_marking_ ||  !abort_incremental_marking_);

[Hannes Payer (out of office), 2015-04-15 06:44:04]

https://codereview.chromium.org/1082973003/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1082973003/diff/40001/src/heap/heap.h#newcode760
src/heap/heap.h:760: static const int kFinalizeIncrementalMarkingMask = 3;
On 2015/04/14 11:56:49, ulan wrote:
> This should be 4, otherwise it is the same as (kReduceMemoryFootprintMask  |
> kAbortIncrementalMarkingMask)

Uh, yes. Done.

https://codereview.chromium.org/1082973003/diff/40001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1082973003/diff/40001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:27: ((flags & Heap::kFinalizeIncrementalMarkingMask)
!= 0);
On 2015/04/14 11:56:49, ulan wrote:
> DCHECK(!finalize_incremental_marking_ ||  !abort_incremental_marking_);

Done.

[Hannes Payer (out of office), 2015-04-15 06:44:12]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2015-04-15 06:44:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082973003/40001

[Hannes Payer (out of office), 2015-04-15 06:44:44]

The CQ bit was unchecked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-04-15 06:45:17]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-04-15 06:45:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1082973003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-15 06:45:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082973003/60001

[commit-bot: I haz the power, 2015-04-15 07:10:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-15 07:10:59]

Patchset 4 (id:??) landed as
https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1
Cr-Commit-Position: refs/heads/master@{#27831}

[Michael Achenbach, 2015-04-15 08:29:40]

On 2015/04/15 07:10:59, I haz the power (commit-bot) wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1
> Cr-Commit-Position: refs/heads/master@{#27831}

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...

[Michael Achenbach, 2015-04-15 09:06:57]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1088083002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
and maybe leads to timeouts/crashes on layout test bots:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002.

[Yang, 2015-04-15 09:24:03]

On 2015/04/15 09:06:57, Michael Achenbach wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1088083002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Breaks
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
> and maybe leads to timeouts/crashes on layout test bots:
>
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002.

This CL fixes the arm64 issue that caused this revert:
https://codereview.chromium.org/1088863002/