Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1082973002: [Webapp Refactor] Implement AppRemotingActivity. (Closed)

Created:
5 years, 8 months ago by kelvinp
Modified:
5 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ClientEventHandler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Implement AppRemotingActivity. This CL separates the session state changes handling logic from AppRemoting.js into AppRemotingActivity, to make it more consistent with CRD. In short, 1. Extension logic are moved into AppConnectedView, as a protocol extension is only valid when the session is connected, which has exactly the same lifetime characteristics of AppConnectedView. 2. Connection State logic are moved into AppRemotingActivity. BUG=476132 NOTRY=true Committed: https://crrev.com/4a6581f6f483fb307aa041cca81284f945cb81bd Cr-Commit-Position: refs/heads/master@{#325175}

Patch Set 1 : #

Total comments: 7

Patch Set 2 : Reviewer's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -320 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 2 chunks +1 line, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/app_connected_view.js View 3 chunks +152 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting.js View 1 3 chunks +9 lines, -318 lines 0 comments Download
A remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 1 chunk +173 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kelvinp
PTAL https://codereview.chromium.org/1082973002/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (left): https://codereview.chromium.org/1082973002/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js#oldcode108 remoting/webapp/app_remoting/js/app_remoting.js:108: // TODO(jamiewalch): Remove ClientSession's dependency on remoting.fullscreen No ...
5 years, 8 months ago (2015-04-14 00:46:34 UTC) #3
garykac
https://codereview.chromium.org/1082973002/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (left): https://codereview.chromium.org/1082973002/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js#oldcode108 remoting/webapp/app_remoting/js/app_remoting.js:108: // TODO(jamiewalch): Remove ClientSession's dependency on remoting.fullscreen On 2015/04/14 ...
5 years, 8 months ago (2015-04-15 00:52:37 UTC) #4
garykac
lgtm once the app_capabilities has been moved back as a param for AppRemoting. https://codereview.chromium.org/1082973002/diff/20001/remoting/webapp/app_remoting/js/ar_main.js File ...
5 years, 8 months ago (2015-04-15 01:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082973002/40001
5 years, 8 months ago (2015-04-15 02:21:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-15 02:25:24 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 02:26:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a6581f6f483fb307aa041cca81284f945cb81bd
Cr-Commit-Position: refs/heads/master@{#325175}

Powered by Google App Engine
This is Rietveld 408576698