Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1082953002: Add configure/CMake flags for conditionally building subzero targets. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add configure/CMake flags for conditionally building subzero targets. Enable/disable X8632 vs ARM32, etc. so that a target-specific binary doesn't grow much as we add more targets. Also update LLVM component revisions for: LLVM change: https://codereview.chromium.org/1084753002/ 8284e69: (jvoung@chromium.org) Add some configure/CMake options for enabling/disabling Subzero targets. Later Subzero change: https://codereview.chromium.org/1075363002/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/0b3aba109505d26c90fc21d2cb01374d4ad940fc

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update LLVM too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M pnacl/COMPONENT_REVISIONS View 1 1 chunk +1 line, -1 line 0 comments Download
M pnacl/build.sh View 1 2 chunks +18 lines, -4 lines 0 comments Download
M toolchain_build/toolchain_build_pnacl.py View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-17 22:08:22 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1082953002/diff/1/pnacl/build.sh File pnacl/build.sh (right): https://codereview.chromium.org/1082953002/diff/1/pnacl/build.sh#newcode307 pnacl/build.sh:307: local subzero_targets="" Since we all love writing compact ...
5 years, 8 months ago (2015-04-17 22:28:44 UTC) #3
jvoung (off chromium)
5 years, 8 months ago (2015-04-21 23:46:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0b3aba109505d26c90fc21d2cb01374d4ad940fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698