Issue 1082943002: Adds a ServerViewObserver interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1082943002: Adds a ServerViewObserver interface (Closed)

Created:
5 years, 8 months ago by sky

Modified:
5 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Adds a ServerViewObserver interface I kept ServerViewDelegate too as the two interfaces are not exactly the same, and I didn't want the Observer interface to take non-const arguments. R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/643231aa965a0ddbb8ae5b14139a31e7ac12e4a6

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : grammar #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -157 lines)			Patch
M	services/view_manager/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	services/view_manager/connection_manager.h	View	1	4 chunks	+18 lines, -7 lines	0 comments	Download
M	services/view_manager/connection_manager.cc	View	1 2	8 chunks	+51 lines, -37 lines	0 comments	Download
M	services/view_manager/server_view.h	View		4 chunks	+7 lines, -0 lines	0 comments	Download
M	services/view_manager/server_view.cc	View		10 chunks	+33 lines, -11 lines	0 comments	Download
M	services/view_manager/server_view_delegate.h	View		1 chunk	+11 lines, -28 lines	0 comments	Download
A +	services/view_manager/server_view_observer.h	View		2 chunks	+16 lines, -20 lines	0 comments	Download
M	services/view_manager/test_server_view_delegate.h	View		1 chunk	+5 lines, -20 lines	0 comments	Download
M	services/view_manager/test_server_view_delegate.cc	View		1 chunk	+6 lines, -33 lines	0 comments	Download
M	services/view_manager/view_manager_service_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm https://codereview.chromium.org/1082943002/diff/20001/services/view_manager/connection_manager.cc File services/view_manager/connection_manager.cc (right): https://codereview.chromium.org/1082943002/diff/20001/services/view_manager/connection_manager.cc#newcode387 services/view_manager/connection_manager.cc:387: // hide to. Reparent so that animations are ...

5 years, 8 months ago (2015-04-13 23:09:00 UTC) #2

sky

5 years, 8 months ago (2015-04-13 23:27:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
643231aa965a0ddbb8ae5b14139a31e7ac12e4a6 (presubmit successful).

Expand Messages | Collapse Messages