Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 108293002: Fix a crash in the compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/phi_merge_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 30945)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -649,7 +649,7 @@
// Remove locals that are not in all handlers.
directLocals = new Map<Element, HInstruction>();
joinedLocals.forEach((element, instruction) {
- if (instruction is HPhi
+ if (element != closureData.thisElement
&& instruction.inputs.length != localsHandlers.length) {
joinBlock.removePhi(instruction);
} else {
« no previous file with comments | « no previous file | tests/language/phi_merge_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698