Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7314)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ETU now SetString()'s for empty values Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/permissions/permission_set.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 06ea9b3843c41833f369e957a6756cdb465dd48c..9ee8a9f741483b31a2e807fb3f81a45503b28be5 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -767,20 +767,21 @@ TEST(PermissionsTest, DefaultFunctionAccess) {
{ "bookmarks", false },
{ "cookies", false },
{ "history", false },
- { "tabs.onUpdated", false },
// Make sure we find the module name after stripping '.' and '/'.
{ "browserAction/abcd/onClick", true },
{ "browserAction.abcd.onClick", true },
// Test Tabs functions.
{ "tabs.create", true},
{ "tabs.update", true},
- { "tabs.getSelected", false},
+ { "tabs.getSelected", true},
+ { "tabs.onUpdated", true },
};
scoped_refptr<PermissionSet> empty = new PermissionSet();
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTests); ++i) {
EXPECT_EQ(kTests[i].expect_success,
- empty->HasAccessToFunction(kTests[i].permission_name));
+ empty->HasAccessToFunction(kTests[i].permission_name))
+ << "Permission being tested: " << kTests[i].permission_name;
}
}
« no previous file with comments | « chrome/common/extensions/permissions/permission_set.cc ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698