Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3651)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ETU now SetString()'s for empty values Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_unittest.cc
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index e43ed7ea2a8df6c6e6af86500e91d88c733406b5..ebe75be4caed8a69beb83ec7840ea1c1eb069e04 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -597,7 +597,6 @@ TEST(ExtensionTest, ApiPermissions) {
{ "bookmarks", false },
{ "cookies", false },
{ "history", false },
- { "tabs.onUpdated", false },
// Make sure we find the module name after stripping '.' and '/'.
{ "browserAction/abcd/onClick", true },
{ "browserAction.abcd.onClick", true },
@@ -606,7 +605,8 @@ TEST(ExtensionTest, ApiPermissions) {
{ "tabs.onRemoved", true},
{ "tabs.remove", true},
{ "tabs.update", true},
- { "tabs.getSelected", false},
+ { "tabs.getSelected", true},
+ { "tabs.onUpdated", true },
// Test getPermissionWarnings functions. Only one requires permissions.
{ "management.getPermissionWarningsById", false },
{ "management.getPermissionWarningsByManifest", true },
« no previous file with comments | « chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698