chrome/browser/extensions/browser_extension_window_controller.cc - Issue 10829186: Tabs API is usable without tabs permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: ETU now SetString()'s for empty values Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_extension_window_controller.cc

diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc

index 54792bc536cbe32b235e18ce089f258392a964d6..817971df0b30a6ae3c5a57e5fec4b9b1ffa7cbb8 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.cc

+++ b/chrome/browser/extensions/browser_extension_window_controller.cc

@@ -48,10 +48,12 @@ BrowserExtensionWindowController::CreateWindowValue() const {

}

base::DictionaryValue*

-BrowserExtensionWindowController::CreateWindowValueWithTabs() const {

+BrowserExtensionWindowController::CreateWindowValueWithTabs(

+ const extensions::Extension* extension) const {

DictionaryValue* result = CreateWindowValue();

- result->Set(keys::kTabsKey, ExtensionTabUtil::CreateTabList(browser_));

+ result->Set(keys::kTabsKey, ExtensionTabUtil::CreateTabList(browser_,

+ extension));

return result;

}