Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Side by Side Diff: chrome/browser/ui/views/ash/panel_view_aura.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ETU now SetString()'s for empty values Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/ash/panel_view_aura.h" 5 #include "chrome/browser/ui/views/ash/panel_view_aura.h"
6 6
7 #include "ash/wm/panel_frame_view.h" 7 #include "ash/wm/panel_frame_view.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 9 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
10 #include "chrome/browser/extensions/extension_function_dispatcher.h" 10 #include "chrome/browser/extensions/extension_function_dispatcher.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 class PanelExtensionWindowController : public extensions::WindowController { 182 class PanelExtensionWindowController : public extensions::WindowController {
183 public: 183 public:
184 PanelExtensionWindowController(PanelViewAura* panel_view, 184 PanelExtensionWindowController(PanelViewAura* panel_view,
185 PanelHost* panel_host); 185 PanelHost* panel_host);
186 virtual ~PanelExtensionWindowController(); 186 virtual ~PanelExtensionWindowController();
187 187
188 // Overriden from extensions::WindowController: 188 // Overriden from extensions::WindowController:
189 virtual int GetWindowId() const OVERRIDE; 189 virtual int GetWindowId() const OVERRIDE;
190 virtual std::string GetWindowTypeText() const OVERRIDE; 190 virtual std::string GetWindowTypeText() const OVERRIDE;
191 virtual base::DictionaryValue* CreateWindowValue() const OVERRIDE; 191 virtual base::DictionaryValue* CreateWindowValue() const OVERRIDE;
192 virtual base::DictionaryValue* CreateWindowValueWithTabs() const OVERRIDE; 192 virtual base::DictionaryValue* CreateWindowValueWithTabs(
193 const extensions::Extension* extension) const OVERRIDE;
193 virtual bool CanClose(Reason* reason) const OVERRIDE; 194 virtual bool CanClose(Reason* reason) const OVERRIDE;
194 virtual void SetFullscreenMode(bool is_fullscreen, 195 virtual void SetFullscreenMode(bool is_fullscreen,
195 const GURL& extension_url) const OVERRIDE; 196 const GURL& extension_url) const OVERRIDE;
196 virtual bool IsVisibleToExtension( 197 virtual bool IsVisibleToExtension(
197 const extensions::Extension* extension) const OVERRIDE; 198 const extensions::Extension* extension) const OVERRIDE;
198 199
199 private: 200 private:
200 PanelViewAura* panel_view_; 201 PanelViewAura* panel_view_;
201 PanelHost* panel_host_; 202 PanelHost* panel_host_;
202 203
(...skipping 21 matching lines...) Expand all
224 return keys::kWindowTypeValuePanel; 225 return keys::kWindowTypeValuePanel;
225 } 226 }
226 227
227 base::DictionaryValue* 228 base::DictionaryValue*
228 PanelExtensionWindowController::CreateWindowValue() const { 229 PanelExtensionWindowController::CreateWindowValue() const {
229 DictionaryValue* result = extensions::WindowController::CreateWindowValue(); 230 DictionaryValue* result = extensions::WindowController::CreateWindowValue();
230 return result; 231 return result;
231 } 232 }
232 233
233 base::DictionaryValue* 234 base::DictionaryValue*
234 PanelExtensionWindowController::CreateWindowValueWithTabs() const { 235 PanelExtensionWindowController::CreateWindowValueWithTabs(
236 const extensions::Extension* extension) const {
235 DictionaryValue* result = CreateWindowValue(); 237 DictionaryValue* result = CreateWindowValue();
236 238
237 // TODO(stevenjb): Implement tab interface for Aura panels. 239 // TODO(stevenjb): Implement tab interface for Aura panels.
238 // Currently there is no mechanism to get a tab id without an associated 240 // Currently there is no mechanism to get a tab id without an associated
239 // TabContents. We will need to either add a TabContents for 241 // TabContents. We will need to either add a TabContents for
240 // panels, or add another mechanism for tracking tabs. crbug.com/115532. 242 // panels, or add another mechanism for tracking tabs. crbug.com/115532.
241 243
242 return result; 244 return result;
243 } 245 }
244 246
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 } 451 }
450 452
451 void PanelViewAura::FlashFrame(bool flash) { 453 void PanelViewAura::FlashFrame(bool flash) {
452 // TODO(stevenjb): Implement 454 // TODO(stevenjb): Implement
453 NOTIMPLEMENTED(); 455 NOTIMPLEMENTED();
454 } 456 }
455 457
456 bool PanelViewAura::IsAlwaysOnTop() const { 458 bool PanelViewAura::IsAlwaysOnTop() const {
457 return true; 459 return true;
458 } 460 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/common/extensions/docs/examples/api/bookmarks/basic/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698