Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: src/jump-target-ia32.cc

Issue 10829: Finish porting jump target changes to the ARM platform. The v8 test... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/jump-target-arm.cc ('k') | src/virtual-frame-arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jump-target-ia32.cc
===================================================================
--- src/jump-target-ia32.cc (revision 737)
+++ src/jump-target-ia32.cc (working copy)
@@ -37,11 +37,10 @@
#define __ masm_->
-JumpTarget::JumpTarget(CodeGenerator* cgen) {
- ASSERT(cgen != NULL);
- expected_frame_ = NULL;
- code_generator_ = cgen;
- masm_ = cgen->masm();
+JumpTarget::JumpTarget(CodeGenerator* cgen)
+ : expected_frame_(NULL),
+ code_generator_(cgen),
+ masm_(cgen->masm()) {
}
@@ -64,7 +63,6 @@
// Precondition: there is a current frame. There may or may not be an
// expected frame at the label.
ASSERT(code_generator_ != NULL);
- ASSERT(masm_ != NULL);
VirtualFrame* current_frame = code_generator_->frame();
ASSERT(current_frame != NULL);
@@ -139,20 +137,18 @@
expected_frame_->Adjust(1);
__ call(&label_);
-
// Postcondition: there is both a current frame and an expected frame at
// the label. The current frame is one shorter than the one at the label
- // (which contains the 'return address', ie, the eip register and possibly
- // cs register).
+ // (which contains the return address in memory).
}
void JumpTarget::Bind() {
+ // Precondition: there is either a current frame or an expected frame at
+ // the label (and possibly both). The label is unbound.
ASSERT(code_generator_ != NULL);
ASSERT(masm_ != NULL);
- // Precondition: there is either a current frame or an expected frame at
- // the label (and possibly both). The label is unbound.
VirtualFrame* current_frame = code_generator_->frame();
ASSERT(current_frame != NULL || expected_frame_ != NULL);
ASSERT(!label_.is_bound());
« no previous file with comments | « src/jump-target-arm.cc ('k') | src/virtual-frame-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698