[Sync] Record histogram for mismatched device_ids

[Sync] Record histogram for mismatched device_ids

Server side logs indicate that device_id passed in refresh token
annotation request differs from device_id recorded on LST. Scenario is
not clear how device_id changes between minting LST and sending
annotation request.

It is possible that some programs/tools restore preferences to some
early state therefore removing devic_id from preferences and causing
generation of new device_id. This change adds histogram to see how often
this happens.

R=stanisc@chromium.org
BUG=481596
Committed: https://crrev.com/a3d731e5e0cd0a687cd0883b0d79f0f02bc4a069
Cr-Commit-Position: refs/heads/master@{#327218}

[stanisc, 2015-04-24 23:05:40]

lgtm sync part of the change

https://codereview.chromium.org/1082853007/diff/1/components/sync_driver/devi...
File components/sync_driver/device_info_sync_service.cc (right):

https://codereview.chromium.org/1082853007/diff/1/components/sync_driver/devi...
components/sync_driver/device_info_sync_service.cc:27: // TODO(pavely): Remove
histogram once device_id mismatch is understood.
Perhaps mention the crbug here.

[pavely, 2015-04-27 18:39:35]

pavely@chromium.org changed reviewers:
+ asvitkine@chromium.org

[pavely, 2015-04-27 18:40:35]

+ asvitkine@ for histograms.xml

https://codereview.chromium.org/1082853007/diff/1/components/sync_driver/devi...
File components/sync_driver/device_info_sync_service.cc (right):

https://codereview.chromium.org/1082853007/diff/1/components/sync_driver/devi...
components/sync_driver/device_info_sync_service.cc:27: // TODO(pavely): Remove
histogram once device_id mismatch is understood.
On 2015/04/24 23:05:40, stanisc wrote:
> Perhaps mention the crbug here.

Done.

[Alexei Svitkine (slow), 2015-04-27 19:17:42]

lgtm % comments

Maybe set BUG=481596 on the CL description?

https://codereview.chromium.org/1082853007/diff/20001/components/sync_driver/...
File components/sync_driver/device_info_sync_service.cc (right):

https://codereview.chromium.org/1082853007/diff/20001/components/sync_driver/...
components/sync_driver/device_info_sync_service.cc:7: #include
"base/metrics/histogram.h"
Nit: please include histogram_macros.h instead.

[pavely, 2015-04-27 19:52:34]

https://codereview.chromium.org/1082853007/diff/20001/components/sync_driver/...
File components/sync_driver/device_info_sync_service.cc (right):

https://codereview.chromium.org/1082853007/diff/20001/components/sync_driver/...
components/sync_driver/device_info_sync_service.cc:7: #include
"base/metrics/histogram.h"
On 2015/04/27 19:17:42, Alexei Svitkine wrote:
> Nit: please include histogram_macros.h instead.

Done.

[pavely, 2015-04-27 19:52:37]

The CQ bit was checked by pavely@chromium.org

[pavely, 2015-04-27 19:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
stanisc@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1082853007/#ps40001
(title: "Rebase. Change include to histogram_macros.h")

[commit-bot: I haz the power, 2015-04-27 19:52:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082853007/40001

[pavely, 2015-04-28 01:05:54]

The CQ bit was unchecked by pavely@chromium.org

[pavely, 2015-04-28 01:06:05]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082853007/40001

[commit-bot: I haz the power, 2015-04-28 02:11:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 02:12:46]

Patchset 3 (id:??) landed as
https://crrev.com/a3d731e5e0cd0a687cd0883b0d79f0f02bc4a069
Cr-Commit-Position: refs/heads/master@{#327218}