chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc - Issue 1082833006: Compute the correct maximum contents width when eliding away the description in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc

Issue 1082833006: Compute the correct maximum contents width when eliding away the description in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bug and test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc b/chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc

index f7c3b4b37e9de741d5bbe1a0cf901bbc47f5e33a..85787b3164bdc9ac6e334f2392792d2657afe5b3 100644

--- a/chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc

+++ b/chrome/browser/ui/omnibox/omnibox_popup_model_unittest.cc

@@ -63,7 +63,7 @@ TEST(OmniboxPopupModelTest, ComputeMatchMaxWidths) {

OmniboxPopupModel::ComputeMatchMaxWidths(

contents_width, separator_width, description_width, available_width,

true, &contents_max_width, &description_max_width);

- EXPECT_EQ(contents_width, contents_max_width);

+ EXPECT_EQ(available_width, contents_max_width);

EXPECT_EQ(0, description_max_width);

// Half and half.

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_popup_model.cc ('k') | no next file » | no next file with comments »