Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1082833004: Fix "git cl upload --use-oauth2" not working on Windows when HOME is not set. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Fix "git cl upload --use-oauth2" not working on Windows when HOME is not set. depot_tools' git wrapper for some reason overrides %HOME% to point to depot_tools directory, and thus scripts running as git subprocesses (git_cl.py) use not the same HOME as scripts that run outside of git process tree (depot-tools-auth.py). Instead always use USERPROFILE in auth.py to consistently pick same directory. This issue happens only when HOME is not set globally. It can explain why it wasn't seen earlier. R=iannucci@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M auth.py View 3 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Vadim Sh.
PTAL I had three choices: 1) Do it like in this CL. 2) At same ...
5 years, 8 months ago (2015-04-21 01:17:30 UTC) #1
iannucci
Super gross.... lgtm . meh. should really get rid of the hack in the git ...
5 years, 8 months ago (2015-04-21 01:22:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082833004/1
5 years, 8 months ago (2015-04-21 01:40:47 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 01:44:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294911

Powered by Google App Engine
This is Rietveld 408576698