Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: components/autofill.gypi

Issue 108283005: Moved ipc-specific files from autofill/core to autofill/content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill.gypi
diff --git a/components/autofill.gypi b/components/autofill.gypi
index 87660f705c95f12ae19bf16f3ebfbd816b95d5e0..b2a9eccc187f9094f3ff977dd249fa38623011cd 100644
--- a/components/autofill.gypi
+++ b/components/autofill.gypi
@@ -30,10 +30,8 @@
'target_name': 'autofill_core_common',
'type': 'static_library',
'dependencies': [
+ 'autofill_content_common',
blundell 2013/12/11 15:42:06 The dependency needs to be the other way around: a
jif-google 2013/12/12 09:54:00 Done.
'../base/base.gyp:base',
- '../content/content.gyp:content_common',
- '../ipc/ipc.gyp:ipc',
- '../third_party/WebKit/public/blink.gyp:blink_minimal',
'../ui/gfx/gfx.gyp:gfx',
'../ui/ui.gyp:ui',
'../url/url.gyp:url_lib',
@@ -59,10 +57,6 @@
'autofill/core/browser/android/personal_data_manager_android.cc',
'autofill/core/common/autofill_constants.cc',
'autofill/core/common/autofill_constants.h',
- 'autofill/core/common/autofill_messages.h',
- 'autofill/core/common/autofill_message_generator.cc',
- 'autofill/core/common/autofill_message_generator.h',
- 'autofill/core/common/autofill_param_traits_macros.h',
'autofill/core/common/autofill_pref_names.cc',
'autofill/core/common/autofill_pref_names.h',
'autofill/core/common/autofill_switches.cc',
@@ -87,6 +81,28 @@
},
{
+ 'target_name': 'autofill_content_common',
+ 'type': 'static_library',
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../content/content.gyp:content_common',
+ '../ipc/ipc.gyp:ipc',
+ '../third_party/WebKit/public/blink.gyp:blink_minimal',
+ '../ui/gfx/gfx.gyp:gfx',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(SHARED_INTERMEDIATE_DIR)/autofill'
blundell 2013/12/11 15:42:06 Needs a ','.
jif-google 2013/12/12 09:54:00 Removed the '<(SHARED_INTERMEDIATE_DIR)/autofill'
+ ],
+ 'sources': [
+ 'autofill/content/common/autofill_messages.h',
+ 'autofill/content/common/autofill_message_generator.cc',
+ 'autofill/content/common/autofill_message_generator.h',
+ 'autofill/content/common/autofill_param_traits_macros.h',
+ ],
+ },
+
+ {
'target_name': 'autofill_core_browser',
'type': 'static_library',
'include_dirs': [

Powered by Google App Engine
This is Rietveld 408576698