Chromium Code Reviews| Index: components/autofill.gypi |
| diff --git a/components/autofill.gypi b/components/autofill.gypi |
| index 87660f705c95f12ae19bf16f3ebfbd816b95d5e0..b0b1eabf0ad193f4b101386c9d579fa9f9286d6a 100644 |
| --- a/components/autofill.gypi |
| +++ b/components/autofill.gypi |
| @@ -27,7 +27,7 @@ |
| ['OS != "ios"', { |
| 'targets': [ |
| { |
| - 'target_name': 'autofill_core_common', |
| + 'target_name': 'autofill_content_common', |
|
blundell
2013/12/11 13:32:53
nit: This target would be better-placed directly a
jeanfrancois
2013/12/11 15:01:19
Done.
|
| 'type': 'static_library', |
| 'dependencies': [ |
| '../base/base.gyp:base', |
|
blundell
2013/12/11 13:32:53
This needs a dependency on autofill_core_common.
jeanfrancois
2013/12/11 15:01:19
Done.
|
| @@ -35,6 +35,27 @@ |
| '../ipc/ipc.gyp:ipc', |
| '../third_party/WebKit/public/blink.gyp:blink_minimal', |
| '../ui/gfx/gfx.gyp:gfx', |
| + ], |
|
jeanfrancois
2013/12/11 13:04:46
I haven't included dependencies to 'autofill_jni_h
|
| + 'include_dirs': [ |
| + '..', |
| + '<(SHARED_INTERMEDIATE_DIR)/autofill' |
| + ], |
| + 'sources': [ |
| + 'autofill/content/common/autofill_messages.h', |
| + 'autofill/content/common/autofill_message_generator.cc', |
| + 'autofill/content/common/autofill_message_generator.h', |
| + 'autofill/content/common/autofill_param_traits_macros.h', |
| + ], |
| + }, |
| + |
| + { |
| + 'target_name': 'autofill_core_common', |
| + 'type': 'static_library', |
| + 'dependencies': [ |
| + '../base/base.gyp:base', |
| + '../content/content.gyp:content_common', |
|
blundell
2013/12/11 13:32:53
This dependency can go.
jeanfrancois
2013/12/11 15:01:19
Done.
|
| + '../third_party/WebKit/public/blink.gyp:blink_minimal', |
|
blundell
2013/12/11 13:32:53
This dependency can go.
jeanfrancois
2013/12/11 15:01:19
Done.
|
| + '../ui/gfx/gfx.gyp:gfx', |
| '../ui/ui.gyp:ui', |
| '../url/url.gyp:url_lib', |
|
jif-google
2013/12/11 13:23:56
forgot to add the dependency to autofill_content_c
|
| ], |
| @@ -59,10 +80,6 @@ |
| 'autofill/core/browser/android/personal_data_manager_android.cc', |
| 'autofill/core/common/autofill_constants.cc', |
| 'autofill/core/common/autofill_constants.h', |
| - 'autofill/core/common/autofill_messages.h', |
| - 'autofill/core/common/autofill_message_generator.cc', |
| - 'autofill/core/common/autofill_message_generator.h', |
| - 'autofill/core/common/autofill_param_traits_macros.h', |
| 'autofill/core/common/autofill_pref_names.cc', |
| 'autofill/core/common/autofill_pref_names.h', |
| 'autofill/core/common/autofill_switches.cc', |