Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 1082823002: [IME] Stop sending synthesized keyCode, and send 229 instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing test another way. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index c27a60f74288dd191dd1ba43228c7840c143e1b4..7d25e13aad60d5d020b4fe73ba5290f60e161575 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -433,12 +433,9 @@ public class ImeAdapter {
KeyEvent.changeAction(keyEvent, KeyEvent.ACTION_UP), 0);
}
- // If we do not have autocomplete=off, then always send compose events rather than a
- // guessed keyCode. This addresses http://crbug.com/422685 .
- if ((mTextInputFlags & WebTextInputFlags.AutocompleteOff) == 0) {
- keyCode = COMPOSITION_KEY_CODE;
- modifiers = 0;
- }
+ // Always send compose events. This is a quick fix for http://crbug.com/476497.
+ keyCode = COMPOSITION_KEY_CODE;
+ modifiers = 0;
jdduke (slow) 2015/07/14 16:42:32 Are there any plans to fix this? Are we OK always
huangs 2015/07/14 16:57:44 This is the debate between two view points: A: Th
// When typing, there is no issue sending KeyDown and KeyUp events around the
// composition event because those key events do nothing (other than call JS
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698