Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1082813004: Roll GN (via buildtools) 321178:326666 (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll GN (via buildtools) 321178:326666 This picks up the changes for 'gn help all' and the markdown docs, fixes a bug related to the transitive propagation of public_deps across shared objects, and includes a speculative fix for the WriteFile() failures we're seeing on Windows. TBR=brettw@chromium.org Committed: https://crrev.com/a21c4f2acc0b7b97a65c3c145361aed55c53f769 Cr-Commit-Position: refs/heads/master@{#326704}

Patch Set 1 #

Patch Set 2 : actual buildtools roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082813004/20001
5 years, 8 months ago (2015-04-23 23:18:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 00:39:13 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a21c4f2acc0b7b97a65c3c145361aed55c53f769 Cr-Commit-Position: refs/heads/master@{#326704}
5 years, 8 months ago (2015-04-24 00:40:20 UTC) #7
horo
5 years, 8 months ago (2015-04-24 01:37:04 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1095553006/ by horo@chromium.org.

The reason for reverting is: Caused gyp_flag_compare failure on Linux GN bots.

BUG=480739.

Powered by Google App Engine
This is Rietveld 408576698