Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1082763002: Reduce regexp compiler stack size when not optimizing regexps (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
adamk, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce regexp compiler stack size when not optimizing regexps R=jkummerow@chromium.org BUG=chromium:475705 LOG=y Committed: https://crrev.com/e0be05036fe9fbbd8653f38dd334f6195337e0aa Cr-Commit-Position: refs/heads/master@{#27851}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Fix one more place where we recurse too much #

Patch Set 4 : More recursion limiting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -17 lines) Patch
M src/jsregexp.h View 1 2 3 4 chunks +6 lines, -1 line 0 comments Download
M src/jsregexp.cc View 1 2 3 9 chunks +39 lines, -16 lines 0 comments Download
A test/mjsunit/regress/regress-475705.js View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-13 15:27:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082763002/1
5 years, 8 months ago (2015-04-13 15:33:48 UTC) #3
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-13 15:38:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/4882)
5 years, 8 months ago (2015-04-13 15:59:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082763002/40001
5 years, 8 months ago (2015-04-13 21:39:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/4892)
5 years, 8 months ago (2015-04-13 22:21:12 UTC) #11
adamk
The code looks good, and I'm very happy to have a test, but it looks ...
5 years, 8 months ago (2015-04-13 22:30:14 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082763002/60001
5 years, 8 months ago (2015-04-15 14:18:00 UTC) #16
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-15 14:53:06 UTC) #18
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-15 14:55:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082763002/60001
5 years, 8 months ago (2015-04-15 15:15:49 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-15 15:16:03 UTC) #22
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 15:16:15 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e0be05036fe9fbbd8653f38dd334f6195337e0aa
Cr-Commit-Position: refs/heads/master@{#27851}

Powered by Google App Engine
This is Rietveld 408576698