src/pathops/SkPathOpsTSect.h - Issue 1082753002: fix valgrind uninitialized issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pathops/SkPathOpsTSect.h

Issue 1082753002: fix valgrind uninitialized issue (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pathops/SkPathOpsTSect.h

diff --git a/src/pathops/SkPathOpsTSect.h b/src/pathops/SkPathOpsTSect.h

index ae01a1dcbabbe09b06158c65bf577af38cbff8a6..9d634333301e180c1121a28f2e4734b06cce362e 100644

--- a/src/pathops/SkPathOpsTSect.h

+++ b/src/pathops/SkPathOpsTSect.h

@@ -16,8 +16,8 @@

template<typename TCurve>

class SkTCoincident {

public:

- SkTCoincident()

- : fCoincident(false) {

+ SkTCoincident() {

+ clear();

mtklein 2015/04/13 15:55:19 this-> ?

}

void clear() {

@@ -30,9 +30,8 @@ public:

}

void init() {

- fCoincident = false;

+ clear();

SkDEBUGCODE(fPerpPt.fX = fPerpPt.fY = SK_ScalarNaN);

- SkDEBUGCODE(fPerpT = SK_ScalarNaN);

}

void markCoincident() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »