Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1082753002: fix valgrind uninitialized issue (Closed)

Created:
5 years, 8 months ago by caryclark
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/pathops/SkPathOpsTSect.h View 2 chunks +3 lines, -4 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
caryclark
tested, verified valgrind error is present without patch, runs clean with patch
5 years, 8 months ago (2015-04-13 15:52:18 UTC) #1
mtklein
lgtm https://codereview.chromium.org/1082753002/diff/1/src/pathops/SkPathOpsTSect.h File src/pathops/SkPathOpsTSect.h (right): https://codereview.chromium.org/1082753002/diff/1/src/pathops/SkPathOpsTSect.h#newcode20 src/pathops/SkPathOpsTSect.h:20: clear(); this-> ?
5 years, 8 months ago (2015-04-13 15:55:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082753002/1
5 years, 8 months ago (2015-04-13 16:27:55 UTC) #4
caryclark
On 2015/04/13 15:55:19, mtklein wrote: > lgtm > > https://codereview.chromium.org/1082753002/diff/1/src/pathops/SkPathOpsTSect.h > File src/pathops/SkPathOpsTSect.h (right): > ...
5 years, 8 months ago (2015-04-13 16:28:43 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 16:36:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/697ac1c138e8ff83cb90449ff378a000796f8a04

Powered by Google App Engine
This is Rietveld 408576698