Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 108273002: Add information that some data may not get deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replaced [] and {} with || and ## to be left-to-right/right-to-left independent Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.js
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js
index 5fb745b8eda148d599104fd69ceccfb66d32b597..563a41a88ff829afd58b8f07475460d89149ad54 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.js
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js
@@ -52,6 +52,8 @@ cr.define('options', function() {
}
this.updateCommitButtonState_();
+ this.createStuffRemainsFooter_();
+
$('clear-browser-data-dismiss').onclick = function(event) {
ClearBrowserDataOverlay.dismiss();
};
@@ -64,6 +66,54 @@ cr.define('options', function() {
this.showDeleteHistoryCheckboxes_(show);
},
+ // Create a footer that explains that some content is not cleared by the
+ // clear browsing history dialog.
+ createStuffRemainsFooter_: function() {
+ // The localized string is of the form "Saved [content settings] and
+ // {search engines} will not be cleared and may reflect your browsing
+ // habits.". The following parses out the parts in brackts and braces and
+ // converts them into buttons whereas the remainders are represented as
+ // span elements.
+ var footer =
+ document.querySelector('#some-stuff-remains-footer p');
+ var footerFragments =
+ loadTimeData.getString('contentSettingsAndSearchEnginesRemain')
+ .split(/([|#])/);
+ for (var i = 0; i < footerFragments.length;) {
+ var buttonId = '';
+ if (i + 2 < footerFragments.length) {
+ if (footerFragments[i] == '|' && footerFragments[i + 2] == '|') {
+ buttonId = 'open-content-settings-from-clear-browsing-data';
+ } else if (footerFragments[i] == '#' &&
+ footerFragments[i + 2] == '#') {
+ buttonId = 'open-search-engines-from-clear-browsing-data';
+ }
+ }
+
+ if (buttonId != '') {
+ var button = document.createElement('button');
+ button.setAttribute('id', buttonId);
+ button.setAttribute('class', 'link-button');
+ button.textContent = footerFragments[i + 1];
+ footer.appendChild(button);
+ i += 3;
+ } else {
+ var span = document.createElement('span');
+ span.textContent = footerFragments[i];
+ footer.appendChild(span);
+ i += 1;
+ }
+ }
+ $('open-content-settings-from-clear-browsing-data').onclick =
+ function(event) {
+ OptionsPage.navigateToPage('content');
+ }
+ $('open-search-engines-from-clear-browsing-data').onclick =
+ function(event) {
+ OptionsPage.navigateToPage('searchEngines');
+ }
+ },
+
// Set the enabled state of the commit button.
updateCommitButtonState_: function() {
var checkboxes = document.querySelectorAll(

Powered by Google App Engine
This is Rietveld 408576698