Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1082723005: Fix html_viewer crash in cc when logging into gmail. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix html_viewer crash in cc when logging into gmail. This started in r325086 which added checks to ensure that RenderPassDrawQuads have associated RenderPasses. The latter were sending their RenderPassId across IPC, while the former weren't. The fix is to ensure that RenderPass objects get serialized correctly across mojo IPC. Also delete third_party/mojo_services/src/surfaces/public/cpp which is redundant with mojo/converters/surfaces. BUG=479008 Committed: https://crrev.com/4d03fdf9c5496f8bc323dcea744f2542ddde4ab6 Cr-Commit-Position: refs/heads/master@{#326218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -104 lines) Patch
M components/view_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/display_manager.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo_services/src/surfaces/public/cpp/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/cpp/surfaces_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/mojo_services/src/surfaces/public/cpp/surfaces_utils.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/mojo_services/src/surfaces/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 8 months ago (2015-04-22 01:12:55 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-22 02:14:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082723005/1
5 years, 8 months ago (2015-04-22 02:17:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 02:21:39 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 02:22:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d03fdf9c5496f8bc323dcea744f2542ddde4ab6
Cr-Commit-Position: refs/heads/master@{#326218}

Powered by Google App Engine
This is Rietveld 408576698