Source/core/svg/SVGSVGElement.cpp - Issue 1082723002: Don't consider the viewBox in SVGSVGElement::selfHasRelativeLengths()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGSVGElement.cpp

Issue 1082723002: Don't consider the viewBox in SVGSVGElement::selfHasRelativeLengths() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove 'hasAttribute(SVGNames::viewBoxAttr)' on 'selfHasRelativeLengths()'. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGSVGElement.cpp

diff --git a/Source/core/svg/SVGSVGElement.cpp b/Source/core/svg/SVGSVGElement.cpp

index 975a18185fd47cca234a24f14d969a65d47dc66b..22278a188f1a23c7c5cbd442b067e47608b37593 100644

--- a/Source/core/svg/SVGSVGElement.cpp

+++ b/Source/core/svg/SVGSVGElement.cpp

@@ -609,8 +609,7 @@ bool SVGSVGElement::selfHasRelativeLengths() const

return m_x->currentValue()->isRelative()

|| m_y->currentValue()->isRelative()

|| m_width->currentValue()->isRelative()

- || m_height->currentValue()->isRelative()

- || hasAttribute(SVGNames::viewBoxAttr);

+ || m_height->currentValue()->isRelative();

}

FloatRect SVGSVGElement::currentViewBoxRect() const

« no previous file with comments | « no previous file | no next file » | no next file with comments »