Issue 1082703003: Wrap typed array implementations in functions.

Issue 1082703003: Wrap typed array implementations in functions. (Closed)

Created:
5 years, 8 months ago by Yang

Modified:
5 years, 8 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Wrap typed array implementations in functions. R=mvstanton@chromium.org Committed: https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 Cr-Commit-Position: refs/heads/master@{#27784}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -121 lines)			Patch
M	src/array-iterator.js	View	2 chunks	+53 lines, -53 lines	0 comments	Download
M	src/arraybuffer.js	View	3 chunks	+23 lines, -21 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/string-iterator.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/typedarray.js	View	6 chunks	+36 lines, -43 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082703003/1

5 years, 8 months ago (2015-04-13 11:56:37 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/6fc394a15614b74776f9bbeeb0486f430bdc8597 Cr-Commit-Position: refs/heads/master@{#27784}

5 years, 8 months ago (2015-04-13 12:22:27 UTC) #6

Michael Achenbach

5 years, 8 months ago (2015-04-13 15:39:25 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1086683002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Flaky nosnap failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s...
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20....

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages