Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1082653002: MacViews: Fix LabelTest.ObscuredSurrogatePair (Closed)

Created:
5 years, 8 months ago by tapted
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150401-MacViews-views_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix LabelTest.ObscuredSurrogatePair The test sets text to an G-clef, sizes the text field to fit, then obscures the G-clef with "*". On Mac, a G-clef has a width of 4.36 pixels and a "*" has a width of 6.27 pixels, so when the text field becomes a "*" it is too narrow and needs to be elided. The text field is also too small to hold an ellipsis (13 pixels) so it just shows nothing. The test expects a "*". Fix the test by resizing after obscuring the G-clef rather than before. BUG=378134 TEST=views_unittests Committed: https://crrev.com/85da3ef950c8280dab2d29a322b9131b673f3ada Cr-Commit-Position: refs/heads/master@{#324949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/views/controls/label_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sky, please take a look
5 years, 8 months ago (2015-04-13 06:30:30 UTC) #2
sky
LGTM
5 years, 8 months ago (2015-04-13 15:42:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082653002/1
5 years, 8 months ago (2015-04-13 23:25:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 23:58:21 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 23:59:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85da3ef950c8280dab2d29a322b9131b673f3ada
Cr-Commit-Position: refs/heads/master@{#324949}

Powered by Google App Engine
This is Rietveld 408576698