Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1082623002: Remove GetRawCookies and DeleteCookie implementation. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
jam, Mike West, pfeldman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GetRawCookies and DeleteCookie implementation. BUG=476389 Committed: https://crrev.com/06f7858372ade83b9fc98a7f72b68700b44934a8 Cr-Commit-Position: refs/heads/master@{#325218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -202 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +0 lines, -49 lines 0 comments Download
D content/common/cookie_data.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/common/cookie_data.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +0 lines, -25 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_webcookiejar_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/renderer_webcookiejar_impl.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Take a look please.
5 years, 8 months ago (2015-04-13 09:16:28 UTC) #2
Mike West
On 2015/04/13 at 09:16:28, dgozman wrote: > Take a look please. Drive-by LGTM for removing ...
5 years, 8 months ago (2015-04-13 09:23:22 UTC) #3
dgozman
@jam: take a look as content/ OWNER please.
5 years, 8 months ago (2015-04-14 15:50:56 UTC) #5
jam
lgtm
5 years, 8 months ago (2015-04-14 19:56:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082623002/1
5 years, 8 months ago (2015-04-15 09:34:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 10:43:28 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 10:44:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06f7858372ade83b9fc98a7f72b68700b44934a8
Cr-Commit-Position: refs/heads/master@{#325218}

Powered by Google App Engine
This is Rietveld 408576698