Issue 10826089: Allow chrome://* to always include cookies in secure XHRs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826089: Allow chrome://* to always include cookies in secure XHRs. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer

Modified:
8 years, 4 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow chrome://* to always include cookies in secure XHRs. If the user has third party cookies blocked and a piece of Chrome's web ui needs to make an XHR to a logged in Google service (for example Print Preview talking to Cloud Print) the cookies would be blocked in the request. Consensus on chromium-dev is that content block settings like this should not apply to chrome UI. Also adds unit tests for ShouldAllowAllContent. BUG=136391 TEST=Unit tests should pass. Verify 136391. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149317

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	chrome/browser/content_settings/host_content_settings_map.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/content_settings/host_content_settings_map_unittest.cc	View		2 chunks	+32 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Albert Bodenhamer

Hi Bernhard, Would you mind reviewing this? Thanks.

8 years, 4 months ago (2012-07-31 21:49:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10826089/1

8 years, 4 months ago (2012-07-31 22:22:18 UTC) #3

Change committed as 149317

Expand Messages | Collapse Messages