Source/core/html/shadow/MediaControlElementTypes.cpp - Issue 1082533002: Support text track selection in video controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 1082533002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed container and addressed comments from fs Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControlElementTypes.cpp

diff --git a/Source/core/html/shadow/MediaControlElementTypes.cpp b/Source/core/html/shadow/MediaControlElementTypes.cpp

index 70d738556f731e1bee57b58bf0f4ca9d2a611bc1..8a3dbcf4a80f9466386101201f1871bc16cb242d 100644

--- a/Source/core/html/shadow/MediaControlElementTypes.cpp

+++ b/Source/core/html/shadow/MediaControlElementTypes.cpp

@@ -89,6 +89,12 @@ void MediaControlElement::show()

m_element->removeInlineStyleProperty(CSSPropertyDisplay);

}

+bool MediaControlElement::isVisible()

+ const StylePropertySet* propertySet = m_element->inlineStyle();

+ return !propertySet || !propertySet->hasProperty(CSSPropertyDisplay);

void MediaControlElement::setDisplayType(MediaControlElementType displayType)

{

if (displayType == m_displayType)